Add new parameters by datr93 · Pull Request #9415 · Azure/azure-rest-api-specs

datr93 · 2020-05-11T21:19:19Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
- adding/removing APIs.
- adding/removing properties.
- adding/removing API-version.
- adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-05-11T21:19:35Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-05-11T21:20:59Z

Azure CLI Extension Generation - Release

Installation instruction for service desktopvirtualization [Preview Changes]
az extension add --source=https://sdkautomation.blob.core.windows.net/sdkautomation-pipeline/Azure/azure-rest-api-specs/9415/azure-cli-extensions/Azure/azure-cli-extensions/desktopvirtualization/desktopvirtualization-0.1.0-py3-none-any.whl

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 90d9466 with merge commit 92ee01a. Azure CLI Automation 13.0.17.20200619.4

[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperationList' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'ResourceProviderOperation-display' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (PreCheck/SchemaMissingType): The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'
[AutoRest] WARNING (): cli.auto-parameter-hidden is not true, skip visibility cleaner
[AutoRest] 
[AutoRest] NO TEST SCENARIO PROVIDED - DEFAULT WILL BE USED
[AutoRest] ADD FOLLOWING SECTION TO readme.cli.md FILE TO MODIFY IT
[AutoRest] --------------------------------------------------------
[AutoRest]   test-scenario:
[AutoRest]     - name: /ApplicationGroups/put/ApplicationGroup_Create
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_Get
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_List
[AutoRest]     - name: /ApplicationGroups/get/ApplicationGroup_ListByResourceGroup
[AutoRest]     - name: /ApplicationGroups/patch/ApplicationGroups_Update
[AutoRest]     - name: /HostPools/put/HostPool_Create
[AutoRest]     - name: /HostPools/get/HostPool_Get
[AutoRest]     - name: /HostPools/get/HostPool_List
[AutoRest]     - name: /HostPools/get/HostPool_ListByResourceGroup
[AutoRest]     - name: /HostPools/patch/HostPool_Update
[AutoRest]     - name: /Workspaces/put/Workspace_Create
[AutoRest]     - name: /Workspaces/get/Workspace_Get
[AutoRest]     - name: /Workspaces/get/Workspace_ListByResourceGroup
[AutoRest]     - name: /Workspaces/get/Workspace_ListBySubscription
[AutoRest]     - name: /Workspaces/patch/Workspace_Update
[AutoRest]     - name: /ApplicationGroups/delete/ApplicationGroup_Delete
[AutoRest]     - name: /HostPools/delete/HostPool_Delete
[AutoRest]     - name: /Workspaces/delete/Workspace_Delete
[AutoRest] --------------------------------------------------------

️✔️desktopvirtualization [View full logs] [Release Azure CLI Changes]
- desktopvirtualization-0.1.0-py3-none-any.whl
- desktopvirtualization-0.1.0.zip

openapi-sdkautomation · 2020-05-11T21:21:09Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 90d9466 with merge commit 92ee01a. SDK Automation 13.0.17.20200619.4
️✔️preview/desktopvirtualization/mgmt/2019-01-23-preview [View full logs] [Release SDK Changes]
- preview.desktopvirtualization.mgmt.2019-01-23-preview.zip
️✔️preview/desktopvirtualization/mgmt/2019-09-24-preview [View full logs] [Release SDK Changes]
- preview.desktopvirtualization.mgmt.2019-09-24-preview.zip
️✔️preview/desktopvirtualization/mgmt/2019-12-10-preview [View full logs] [Release SDK Changes]
- preview.desktopvirtualization.mgmt.2019-12-10-preview.zip

openapi-sdkautomation · 2020-05-11T21:21:11Z

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 90d9466 with merge commit 92ee01a. SDK Automation 13.0.17.20200619.4
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2020-05-11T21:21:16Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 90d9466 with merge commit 92ee01a. SDK Automation 13.0.17.20200619.4
️✔️sdk/desktopvirtualization/mgmt-v2019_12_10_preview [View full logs] [Release SDK Changes]

openapi-sdkautomation · 2020-05-11T21:21:29Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 90d9466 with merge commit 92ee01a. SDK Automation 13.0.17.20200619.4
```
[azure-mgmt-desktopvirtualization][ChangeLog] WARNING: Failed to generate ChangeLog.
```

⚠️azure-mgmt-desktopvirtualization [View full logs] [Release SDK Changes]

[build_conf] INFO:packaging_tools:Building template azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-desktopvirtualization
[build_conf] INFO:packaging_tools:Template done azure-mgmt-desktopvirtualization
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
Not exact 2 reports found:
Not generating changelog.
[ChangeLog] WARNING: Failed to generate ChangeLog.

openapi-sdkautomation · 2020-05-11T21:21:32Z

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-05-11T21:21:45Z

azure-sdk-for-trenton

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azuresdkci · 2020-05-11T21:57:08Z

Can one of the admins verify this patch?

openapi-pipeline-app · 2020-06-12T22:15:49Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

azure-pipelines · 2020-06-12T22:15:57Z

Comment was made before the most recent commit for PR 9415 in repo Azure/azure-rest-api-specs

azure-pipelines · 2020-06-12T22:27:28Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-06-12T22:31:22Z

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-06-12T22:31:51Z

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-06-12T23:05:59Z

Azure Pipelines successfully started running 1 pipeline(s).

...anager/Microsoft.DesktopVirtualization/preview/2019-01-23-preview/desktopvirtualization.json

azure-pipelines · 2020-06-16T00:51:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-16T00:53:51Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-16T00:58:58Z

Azure Pipelines successfully started running 1 pipeline(s).

datr93 · 2020-06-16T18:18:36Z

@markcowl sorry we need one more breaking change to review.

...anager/Microsoft.DesktopVirtualization/preview/2019-01-23-preview/desktopvirtualization.json

...anager/Microsoft.DesktopVirtualization/preview/2019-09-24-preview/desktopvirtualization.json

...anager/Microsoft.DesktopVirtualization/preview/2019-12-10-preview/desktopvirtualization.json

azure-pipelines · 2020-06-19T00:50:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-06-19T00:57:50Z

Azure Pipelines successfully started running 1 pipeline(s).

markcowl

Need to fix examples to include the newly required property

* preferred type and vm resoure id * spelling * remove get activeApp, get appGroupAssignments * pr comments * fix example

openapi-assignment-bot bot assigned markcowl May 11, 2020

This was referenced May 11, 2020

[AutoPR azure-mgmt-DesktopVirtualization] Remove unused routes AzureSDKAutomation/azure-sdk-for-python#1056

Closed

[AutoPR sdk/desktopvirtualization/mgmt-v2019_12_10_preview] Add new parameters AzureSDKAutomation/azure-sdk-for-java#3097

Closed

datr93 force-pushed the master branch from 3648a5f to 4049d0d Compare June 12, 2020 22:15

openapi-sdkautomation bot mentioned this pull request Jun 12, 2020

[AutoPR desktopvirtualization] Add new parameters AzureSDKAutomation/azure-cli-extensions#113

Closed

openapi-sdkautomation bot mentioned this pull request Jun 12, 2020

[AutoPR azure-mgmt-desktopvirtualization] Add new parameters AzureSDKAutomation/azure-sdk-for-python#1419

Closed

preferred type and vm resoure id

cebf3c8

datr93 force-pushed the master branch from a7df3c7 to cebf3c8 Compare June 12, 2020 23:05

datr93 changed the title ~~Remove unused routes~~ Add new parameters Jun 15, 2020

markcowl requested changes Jun 16, 2020

View reviewed changes

...anager/Microsoft.DesktopVirtualization/preview/2019-01-23-preview/desktopvirtualization.json Outdated Show resolved Hide resolved

markcowl added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jun 16, 2020

markcowl assigned datr93 Jun 16, 2020

spelling

dcdc625

datr93 force-pushed the master branch from b0455df to dcdc625 Compare June 16, 2020 00:53

remove get activeApp, get appGroupAssignments

693f6d6

datr93 requested a review from markcowl June 18, 2020 17:07

markcowl removed Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Jun 19, 2020

markcowl requested changes Jun 19, 2020

View reviewed changes

markcowl added Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Jun 19, 2020

pr comments

ec26de2

markcowl approved these changes Jun 19, 2020

View reviewed changes

fix example

90d9466

markcowl requested changes Jun 19, 2020

View reviewed changes

datr93 requested a review from markcowl June 19, 2020 01:07

markcowl approved these changes Jun 22, 2020

View reviewed changes

markcowl removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Jun 22, 2020

akning-ms merged commit 92ee01a into Azure:master Jun 24, 2020

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Add new parameters (Azure#9415)

3aed46c

* preferred type and vm resoure id * spelling * remove get activeApp, get appGroupAssignments * pr comments * fix example

Conversation

datr93 commented May 11, 2020

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented May 11, 2020

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Azure CLI Extension Generation - Release

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-trenton

Uh oh!

azuresdkci commented May 11, 2020

Uh oh!

openapi-pipeline-app bot commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Jun 12, 2020

Uh oh!

azure-pipelines bot commented Jun 12, 2020

Uh oh!

openapi-sdkautomation bot commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python-track2 - Release

Uh oh!

openapi-sdkautomation bot commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Trenton Generation - Release

Uh oh!

azure-pipelines bot commented Jun 12, 2020

Uh oh!

Uh oh!

azure-pipelines bot commented Jun 16, 2020

Uh oh!

azure-pipelines bot commented Jun 16, 2020

Uh oh!

azure-pipelines bot commented Jun 16, 2020

Uh oh!

datr93 commented Jun 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-pipelines bot commented Jun 19, 2020

Uh oh!

azure-pipelines bot commented Jun 19, 2020

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-sdkautomation bot commented May 11, 2020 •

edited

Loading

openapi-pipeline-app bot commented Jun 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 12, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jun 12, 2020 •

edited

Loading